linux-kernel - Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918152928.GF6335@gaia>
Date:   Fri, 18 Sep 2020 16:29:29 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Marco Elver <elver@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Elena Petrova <lenaptr@...gle.com>,
        Branislav Rankov <Branislav.Rankov@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Will Deacon <will.deacon@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata

On Fri, Sep 18, 2020 at 04:55:45PM +0200, Andrey Konovalov wrote:
> On Fri, Sep 18, 2020 at 4:44 PM Marco Elver <elver@...gle.com> wrote:
> >
> > On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
> > [...]
> > >  static void set_track(struct kmem_cache *s, void *object,
> > > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object,
> > >               unsigned int nr_entries;
> > >
> > >               metadata_access_enable();
> > > -             nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3);
> > > +             nr_entries = stack_trace_save(kasan_reset_tag(p->addrs),
> > > +                                             TRACK_ADDRS_COUNT, 3);
> >
> > Suggested edit (below 100 cols):
> >
> > -               nr_entries = stack_trace_save(kasan_reset_tag(p->addrs),
> > -                                               TRACK_ADDRS_COUNT, 3);
> > +               nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3);
> 
> Ah, yes, it's a 100 lines now :) Will do in v3, thanks!

Don't get too carried way ;). The preferred limit is still 80, as per
Documentation/process/coding-style.rst (and commit bdc48fa11e46), unless
it significantly increases readability and does not hide information.
The checkpatch.pl was changed as not to make 80 a hard limit (and so an
arbitrary higher limit was picked).

What (to me) would increase readability above is aligning the
descendants to the open function parenthesis rather than increasing the
line length. Anyway, it's up to you on the kasan code, just don't bother
changing the patches for longer lines in arch/arm64.

-- 
Catalin