lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 18 Sep 2020 10:07:51 -0600
From:   Rob Herring <robh@...nel.org>
To:     Yong Wu <yong.wu@...iatek.com>
Cc:     Joerg Roedel <joro@...tes.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Tomasz Figa <tfiga@...gle.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        srv_heupstream <srv_heupstream@...iatek.com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux IOMMU <iommu@...ts.linux-foundation.org>,
        Youlin Pei <youlin.pei@...iatek.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Anan Sun <anan.sun@...iatek.com>,
        Chao Hao <chao.hao@...iatek.com>,
        Ming-Fan Chen <ming-fan.chen@...iatek.com>
Subject: Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to
 DT schema

On Mon, Sep 14, 2020 at 11:51 PM Yong Wu <yong.wu@...iatek.com> wrote:
>
> On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote:
> > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote:
> > > Convert MediaTek IOMMU to DT schema.
> > >
> > > Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> > > ---
>
> [...]
>
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - mediatek,mt2701-m4u #mt2701 generation one HW
> > > +      - mediatek,mt2712-m4u #mt2712 generation two HW
> > > +      - mediatek,mt6779-m4u #mt6779 generation two HW
> > > +      - mediatek,mt7623-m4u, mediatek,mt2701-m4u #mt7623 generation one HW
> >
> > This is not right.
> >
> > items:
> >   - const: mediatek,mt7623-m4u
> >   - const: mediatek,mt2701-m4u
> >
> > And that has to be under a 'oneOf' with the rest of this.
>
> Thanks for the review. Is this OK?
>
>   compatible:
>     oneOf:
>       - const: mediatek,mt2701-m4u # mt2701 generation one HW
>       - const: mediatek,mt2712-m4u # mt2712 generation two HW
>       - const: mediatek,mt6779-m4u # mt6779 generation two HW
>       - const: mediatek,mt8173-m4u # mt8173 generation two HW
>       - const: mediatek,mt8183-m4u # mt8183 generation two HW
>       - const: mediatek,mt8192-m4u # mt8192 generation two HW

It is correct, but I prefer all these to be a single enum. So 'oneOf'
would have 2 entries.

>       - description: mt7623 generation one HW
>         items:
>           - const: mediatek,mt7623-m4u
>           - const: mediatek,mt2701-m4u
>
> >
> > > +      - mediatek,mt8173-m4u #mt8173 generation two HW
> > > +      - mediatek,mt8183-m4u #mt8183 generation two HW
> > > +
> > > +  reg:
> > > +    maxItems: 1
>
> [snip]

Powered by blists - more mailing lists