linux-kernel - Re: [PATCH] ftrace: Free the trampoline when ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200918122008.7b21f77e@gandalf.local.home>
Date:   Fri, 18 Sep 2020 12:20:08 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     mingo@...hat.com, peterz@...radead.org, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, mhiramat@...nel.org
Subject: Re: [PATCH] ftrace: Free the trampoline when ftrace_startup() fails

On Mon, 31 Aug 2020 14:56:57 +0200 (CEST)
Miroslav Benes <mbenes@...e.cz> wrote:

> I used Masami's address which did not work. Sorry about that. Should be ok 
> now.

Thanks Miroslav,

I've queued this up to be tested and pushed as urgent.

-- Steve

> 
> On Mon, 31 Aug 2020, Miroslav Benes wrote:
> 
> > Commit fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
> > missed to remove ops from new ftrace_ops_trampoline_list in
> > ftrace_startup() if ftrace_hash_ipmodify_enable() fails there. It may
> > lead to BUG if such ops come from a module which may be removed.
> > 
> > Moreover, the trampoline itself is not freed in this case.
> > 
> > Fix it by calling ftrace_trampoline_free() during the rollback.
> > 
> > Fixes: fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
> > Signed-off-by: Miroslav Benes <mbenes@...e.cz>
> > ---
> >