linux-kernel - Re: [PATCH] scsi: arcmsr: Remove the superfluous break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ce1124d-7f83-d9aa-f62a-519c8914ad98@kernel.dk>
Date:   Fri, 18 Sep 2020 11:17:46 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Joe Perches <joe@...ches.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        lee.jones@...aro.org, colin.king@...onical.com,
        mchehab+huawei@...nel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] scsi: arcmsr: Remove the superfluous break

On 9/18/20 11:13 AM, Joe Perches wrote:
> On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote:
>> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
>>> Remove the superfluous break, as there is a 'return' before it.
>>>
>>
>> Apparently, the change is correct. Please, just add a proper Fixes tag by
>> yourself this time.
> 
> There's no need for a "Fixes:" here, it's purely cosmetic.
> 
> btw:
> 
> There are at least 150 instances of
> 	return foo(...);
> 	break;
> still in the kernel tree:

A lot of these are false positives, since they follow a pattern of:

if (some_condition)
	return func();
break;

-- 
Jens Axboe