linux-kernel - Re: [PATCH v4] net: use exponential backoff in netdev_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200918.134754.204300318220602155.davem@davemloft.net>
Date:   Fri, 18 Sep 2020 13:47:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fruggeri@...sta.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com, ap420073@...il.com, andriin@...com,
        edumazet@...gle.com, jiri@...lanox.com, ast@...nel.org,
        kuba@...nel.org
Subject: Re: [PATCH v4] net: use exponential backoff in netdev_wait_allrefs

From: fruggeri@...sta.com (Francesco Ruggeri)
Date: Fri, 18 Sep 2020 13:19:01 -0700

> The combination of aca_free_rcu, introduced in commit 2384d02520ff
> ("net/ipv6: Add anycast addresses to a global hashtable"), and
> fib6_info_destroy_rcu, introduced in commit 9b0a8da8c4c6 ("net/ipv6:
> respect rcu grace period before freeing fib6_info"), can result in
> an extra rcu grace period being needed when deleting an interface,
> with the result that netdev_wait_allrefs ends up hitting the msleep(250),
> which is considerably longer than the required grace period.
> This can result in long delays when deleting a large number of interfaces,
> and it can be observed with this script:
  ...
> Time with this patch on a 5.4 kernel:
> 
> real	0m7.704s
> user	0m0.385s
> sys	0m1.230s
> 
> Time without this patch:
> 
> real    0m31.522s
> user    0m0.438s
> sys     0m1.156s
> 
> v2: use exponential backoff instead of trying to wake up
>     netdev_wait_allrefs.
> v3: preserve reverse christmas tree ordering of local variables
> v4: try an extra rcu_barrier before the backoff, plus some
>     cosmetic changes.
> 
> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>

Applied to net-next, thanks.