linux-kernel - Re: WARNING in ex_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918235528.GB3421308@ZenIV.linux.org.uk>
Date:   Sat, 19 Sep 2020 00:55:28 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     syzbot <syzbot+ea3a78a71705faf41d77@...kaller.appspotmail.com>,
        Aleksa Sarai <cyphar@...har.com>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        syzkaller-bugs@...glegroups.com,
        Thomas Gleixner <tglx@...utronix.de>, X86 ML <x86@...nel.org>
Subject: Re: WARNING in ex_handler_uaccess

On Fri, Sep 18, 2020 at 04:31:33PM -0700, Andy Lutomirski wrote:

> check_zeroed_user() looks buggy.  It does:
> 
>        if (!user_access_begin(from, size))
>                return -EFAULT;
> 
>        unsafe_get_user(val, (unsigned long __user *) from, err_fault);
> 
> This is wrong if size < sizeof(unsigned long) -- you read outside the
> area you verified using user_access_begin().

Read the code immediately prior to that.  from will be word-aligned,
and size will be extended accordingly.  If the area acceptable for
user_access_begin() ends *NOT* on a word boundary, you have a problem
and I would strongly recommend to seek professional help.

All reads in that thing are word-aligned and word-sized.  So I very
much doubt that your analysis is correct.