linux-kernel - Re: [PATCH 3/3] hwmon: (lm75) Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5863e71-2531-b0de-c432-4bc2967d56c8@roeck-us.net>
Date:   Thu, 17 Sep 2020 19:04:51 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mark Brown <broonie@...nel.org>, Alban Bedel <alban.bedel@...q.com>
Cc:     linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support

On 9/17/20 4:00 AM, Mark Brown wrote:
> On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote:
> 
>> +	data->vs = devm_regulator_get_optional(dev, "vs");
>> +	if (IS_ERR(data->vs)) {
> 
> Unless the device can work without power you should not be using
> regulator_get_optional().
> 

The driver works today without regulator, and needs to continue
doing so.

Guenter



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)