linux-kernel - Re: [PATCH v3 0/10] libperf and arm64 userspace counter access support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANW9uyu_q=xd-nG==GeDrxkwBSu1EycaSKJnm5LH4=K4gh8PPw@mail.gmail.com>
Date:   Sat, 19 Sep 2020 16:22:45 +0900
From:   Itaru Kitayama <itaru.kitayama@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Honnappa Nagarahalli <honnappa.nagarahalli@....com>,
        Ian Rogers <irogers@...gle.com>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Raphael Gault <raphael.gault@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/10] libperf and arm64 userspace counter access support

Rob,
V3 fails to build on ThunderX2:

$ make
  BUILD:   Doing 'make -j224' parallel build

Auto-detecting system features:
...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ OFF ]
...                        libbfd: [ on  ]
...                        libcap: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                     libcrypto: [ on  ]
...                     libunwind: [ OFF ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ OFF ]
...                           bpf: [ on  ]
...                        libaio: [ on  ]
...                       libzstd: [ on  ]
...        disassembler-four-args: [ on  ]

Makefile.config:604: No libunwind found. Please install
libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
Makefile.config:730: GTK2 not found, disables GTK2 support. Please
install gtk2-devel or libgtk2.0-dev
Makefile.config:965: No libbabeltrace found, disables 'perf data' CTF
format support, please install
libbabeltrace-dev[el]/libbabeltrace-ctf-dev
Makefile.config:1009: No openjdk development package found, please
install JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
  CC       arch/arm64/tests/user-events.o
  CC       arch/arm64/tests/arch-tests.o
In file included from arch/arm64/tests/arch-tests.c:4:
/home/users/itaru.kitayama/projects/linux/tools/perf/arch/arm64/include/arch-tests.h:10:5:
error: redundant redeclaration of ‘test__arch_unwind_sample’
[-Werror=redundant-decls]
 int test__arch_unwind_sample(struct perf_sample *sample,
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/arm64/tests/arch-tests.c:3:
/home/users/itaru.kitayama/projects/linux/tools/perf/tests/tests.h:134:5:
note: previous declaration of ‘test__arch_unwind_sample’ was here
 int test__arch_unwind_sample(struct perf_sample *sample,
     ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [/home/users/itaru.kitayama/projects/linux/tools/build/Makefile.build:97:
arch/arm64/tests/arch-tests.o] Error 1
make[6]: *** Waiting for unfinished jobs....
In file included from arch/arm64/tests/user-events.c:13:
/home/users/itaru.kitayama/projects/linux/tools/perf/arch/arm64/include/arch-tests.h:10:5:
error: redundant redeclaration of ‘test__arch_unwind_sample’
[-Werror=redundant-decls]
 int test__arch_unwind_sample(struct perf_sample *sample,
     ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/arm64/tests/user-events.c:12:
/home/users/itaru.kitayama/projects/linux/tools/perf/tests/tests.h:134:5:
note: previous declaration of ‘test__arch_unwind_sample’ was here
 int test__arch_unwind_sample(struct perf_sample *sample,
     ^~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/tests/user-events.c: In function ‘perf_init’:
arch/arm64/tests/user-events.c:106:7: error: too few arguments to
function ‘perf_evsel__mmap’
  if (!perf_evsel__mmap(evsel)) {
       ^~~~~~~~~~~~~~~~
In file included from arch/arm64/tests/user-events.c:8:
/home/users/itaru.kitayama/projects/linux/tools/lib/perf/include/perf/evsel.h:31:19:
note: declared here
 LIBPERF_API void *perf_evsel__mmap(struct perf_evsel *evsel, size_t length);
                   ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [/home/users/itaru.kitayama/projects/linux/tools/build/Makefile.build:97:
arch/arm64/tests/user-events.o] Error 1
make[5]: *** [/home/users/itaru.kitayama/projects/linux/tools/build/Makefile.build:139:
tests] Error 2
make[4]: *** [/home/users/itaru.kitayama/projects/linux/tools/build/Makefile.build:139:
arm64] Error 2
make[3]: *** [/home/users/itaru.kitayama/projects/linux/tools/build/Makefile.build:139:
arch] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:634: perf-in.o] Error 2
make[1]: *** [Makefile.perf:233: sub-make] Error 2
make: *** [Makefile:70: all] Error 2

On Wed, Sep 16, 2020 at 11:50 AM Rob Herring <robh@...nel.org> wrote:
>
> On Mon, Sep 14, 2020 at 5:14 PM Itaru Kitayama <itaru.kitayama@...il.com> wrote:
> >
> > Could you point us to your repo too?
>
> Sure, pushed a branch here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git user-perf-event-v3
>
> Rob