linux-kernel - Re: [PATCH leds v2 03/50] leds: fsg: compile if COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200919095616.GA14795@duo.ucw.cz>
Date:   Sat, 19 Sep 2020 11:56:16 +0200
From:   Pavel Machek <pavel@....cz>
To:     Marek Behún <marek.behun@....cz>
Cc:     linux-leds@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        Ondřej Jirman <megous@...ous.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, Rod Whitby <rod@...tby.id.au>
Subject: Re: [PATCH leds v2 03/50] leds: fsg: compile if COMPILE_TEST=y

On Fri 2020-09-18 00:32:51, Marek Behún wrote:
> This driver can be compiled on other platforms with small change if
> COMPILE_TEST=y.
> 
> Signed-off-by: Marek Behún <marek.behun@....cz>

> +++ b/drivers/leds/leds-fsg.c
> @@ -16,7 +16,13 @@
>  #include <linux/leds.h>
>  #include <linux/module.h>
>  #include <linux/io.h>
> +
> +#if IS_ENABLED(MACH_FSG)
>  #include <mach/hardware.h>
> +#else
> +/* for COMPILE_TEST */
> +#define IXP4XX_EXP_BUS_BASE(x) (0x12345678 + (x))
> +#endif

This is _way_ too ugly and I'd have to read the driver to understand
what prevents it from using this address and corrupting something, somewhere.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)