linux-kernel - Re: [PATCH] staging: media: atomisp: Don't do unnecessary zeroing of memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e70df97-808a-6d23-c24e-4b7c905cccda@gmail.com>
Date:   Sat, 19 Sep 2020 20:31:23 +0100
From:   Alex Dewar <alex.dewar90@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Don't do unnecessary zeroing of
 memory

On 2020-09-09 21:48, Alex Dewar wrote:
> In a few places in pci/sh_css_params.c, memset is used to zero memory
> immediately before it is freed. As none of these structs appear to
> contain sensitive information, just remove the calls to memset.
Friendly ping?
>
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
>   drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
> index 2c67c23b3700..24fc497bd491 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_params.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
> @@ -4378,7 +4378,6 @@ ia_css_3a_statistics_free(struct ia_css_3a_statistics *me)
>   	if (me) {
>   		kvfree(me->rgby_data);
>   		kvfree(me->data);
> -		memset(me, 0, sizeof(struct ia_css_3a_statistics));
>   		kvfree(me);
>   	}
>   }
> @@ -4417,7 +4416,6 @@ ia_css_dvs_statistics_free(struct ia_css_dvs_statistics *me)
>   	if (me) {
>   		kvfree(me->hor_proj);
>   		kvfree(me->ver_proj);
> -		memset(me, 0, sizeof(struct ia_css_dvs_statistics));
>   		kvfree(me);
>   	}
>   }
> @@ -4459,7 +4457,6 @@ ia_css_dvs_coefficients_free(struct ia_css_dvs_coefficients *me)
>   	if (me) {
>   		kvfree(me->hor_coefs);
>   		kvfree(me->ver_coefs);
> -		memset(me, 0, sizeof(struct ia_css_dvs_coefficients));
>   		kvfree(me);
>   	}
>   }
> @@ -4551,7 +4548,6 @@ ia_css_dvs2_statistics_free(struct ia_css_dvs2_statistics *me)
>   		kvfree(me->ver_prod.odd_imag);
>   		kvfree(me->ver_prod.even_real);
>   		kvfree(me->ver_prod.even_imag);
> -		memset(me, 0, sizeof(struct ia_css_dvs2_statistics));
>   		kvfree(me);
>   	}
>   }
> @@ -4635,7 +4631,6 @@ ia_css_dvs2_coefficients_free(struct ia_css_dvs2_coefficients *me)
>   		kvfree(me->ver_coefs.odd_imag);
>   		kvfree(me->ver_coefs.even_real);
>   		kvfree(me->ver_coefs.even_imag);
> -		memset(me, 0, sizeof(struct ia_css_dvs2_coefficients));
>   		kvfree(me);
>   	}
>   }
> @@ -4710,7 +4705,6 @@ ia_css_dvs2_6axis_config_free(struct ia_css_dvs_6axis_config *dvs_6axis_config)
>   		kvfree(dvs_6axis_config->ycoords_y);
>   		kvfree(dvs_6axis_config->xcoords_uv);
>   		kvfree(dvs_6axis_config->ycoords_uv);
> -		memset(dvs_6axis_config, 0, sizeof(struct ia_css_dvs_6axis_config));
>   		kvfree(dvs_6axis_config);
>   	}
>   }