linux-kernel - Re: [PATCH net-next] net: microchip: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Sep 2020 14:09:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengyongjun3@...wei.com
Cc:     bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: microchip: Remove set but not used
 variable

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Sat, 19 Sep 2020 10:37:32 +0800

> `ret` is never used, so remove it.

You are not removing it:

> @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
>  	/* Host sets PME_En, put D3hot */
>  	ret = pci_prepare_to_sleep(pdev);
>  
> -	return 0;
> +	return ret;
>  }

In fact, you are making it get used properly.

Please fix your commit message.