linux-kernel - Re: [PATCH net-next] net: natsemi: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 19 Sep 2020 14:10:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengyongjun3@...wei.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: natsemi: Remove set but not used variable

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Sat, 19 Sep 2020 10:46:44 +0800

> @@ -1226,8 +1226,8 @@ static int ns83820_get_link_ksettings(struct net_device *ndev,
>  
>  	/* read current configuration */
>  	cfg   = readl(dev->base + CFG) ^ SPDSTS_POLARITY;
> -	tanar = readl(dev->base + TANAR);
>  	tbicr = readl(dev->base + TBICR);
> +	readl(dev->base + TANAR);
>  

Please do not change the order of the readl() operations, it might
matter.