linux-kernel - Re: [PATCH -next v2] memory: emif: Convert to DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200920165933.GB16677@kozik-lap>
Date:   Sun, 20 Sep 2020 18:59:33 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v2] memory: emif: Convert to DEFINE_SHOW_ATTRIBUTE

On Thu, Sep 17, 2020 at 08:51:13PM +0800, Qinglang Miao wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Along with this change, we get additionally:
>         .owner          = THIS_MODULE,
>         .llseek         = seq_lseek,
> 
> 1. The llseek method is used to change the current read/write position
> in a file which can be ignored if you don't use it.
> 2. The owner is not even a method. Instead, it is a pointer to the
> module that “owns” this structure; it is used by the kernel to maintain
> the module's usage count which can be ignored.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
> v2: based on linux-next(20200917), and can be applied to
>     mainline cleanly now.
> 
>  drivers/memory/emif.c | 22 ++--------------------

Thanks, applied.

Best regards,
Krzysztof