linux-kernel - Re: ledtrig-cpu: Limit to 4 CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Sep 2020 20:34:01 +0200
From:   Pavel Machek <pavel@....cz>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     linux-leds@...r.kernel.org, dmurphy@...com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: ledtrig-cpu: Limit to 4 CPUs

Hi!

> >    *
> >    * It can be bound to any LED just like other triggers using either a
> >    * board file or via sysfs interface.
> >    *
> >    * An API named ledtrig_cpu is exported for any user, who want to add CPU
> > - * activity indication in their code
> > + * activity indication in their code.
> >    *
> >    * Copyright 2011 Linus Walleij <linus.walleij@...aro.org>
> >    * Copyright 2011 - 2012 Bryan Wu <bryan.wu@...onical.com>
> > @@ -145,6 +149,9 @@ static int __init ledtrig_cpu_init(void)
> >   	for_each_possible_cpu(cpu) {
> >   		struct led_trigger_cpu *trig = &per_cpu(cpu_trig, cpu);
> > +		if (cpu > 4)
> 
> NACK. The workaround for this trigger was implemented for a reason -
> to make it working on platforms with arbitrary number of logical cpus.
> I've got 8, so I am discriminated now. Not saying, that it precludes
> trigger registration with no single line of warning.

Can I get details of your setup?

What CPU type that is, and how are you mapping CPU activity to LEDs?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)