linux-kernel - Re: [PATCH v3 01/19] ASoC: sun4i-i2s: Add support for H6 I2S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJiuCcenXE_BZpk7smwaddsgqwq7LmhCQuH9T1pG2twM4Uu+mA@mail.gmail.com>
Date:   Sun, 20 Sep 2020 21:38:17 +0200
From:   Clément Péron <peron.clem@...il.com>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Marcus Cooper <codekipper@...il.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v3 01/19] ASoC: sun4i-i2s: Add support for H6 I2S

Hi Samuel,

On Sun, 20 Sep 2020 at 20:39, Samuel Holland <samuel@...lland.org> wrote:
>
> On 9/20/20 1:07 PM, Clément Péron wrote:
> > From: Jernej Skrabec <jernej.skrabec@...l.net>
> >
> > H6 I2S is very similar to that in H3, except it supports up to 16
> > channels.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@...l.net>
> > Signed-off-by: Marcus Cooper <codekipper@...il.com>
> > Signed-off-by: Clément Péron <peron.clem@...il.com>
> > ---
> >  sound/soc/sunxi/sun4i-i2s.c | 218 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 218 insertions(+)
> >
> > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> > index f23ff29e7c1d..348057464bed 100644
> > --- a/sound/soc/sunxi/sun4i-i2s.c
> > +++ b/sound/soc/sunxi/sun4i-i2s.c
> ...
> > @@ -699,6 +770,102 @@ static int sun8i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s,
> >       return 0;
> >  }
> >
> > +static int sun50i_h6_i2s_set_soc_fmt(const struct sun4i_i2s *i2s,
> > +                                  unsigned int fmt)
> > +{
> > +     u32 mode, val;
> > +     u8 offset;
> > +
> > +     /* DAI clock polarity */
> > +     switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> > +     case SND_SOC_DAIFMT_IB_IF:
> > +             /* Invert both clocks */
> > +             val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED |
> > +                   SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
> > +             break;
> > +     case SND_SOC_DAIFMT_IB_NF:
> > +             /* Invert bit clock */
> > +             val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED;
> > +             break;
> > +     case SND_SOC_DAIFMT_NB_IF:
> > +             /* Invert frame clock */
> > +             val = SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
> > +             break;
> > +     case SND_SOC_DAIFMT_NB_NF:
> > +             val = 0;
> > +             break;
> > +     default:
> > +             return -EINVAL;
> > +     }
>
> Maxime's testing that showed LRCK inversion was necessary was done on the H6. So
> in addition to dropping the patch that removed the LRCK inversion for other
> sun8i variants, you need to re-add it to this patch for the H6 variant.

Thanks, you're right!
Clement

>
> Cheers,
> Samuel
>
> > +
> > +     regmap_update_bits(i2s->regmap, SUN4I_I2S_FMT0_REG,
> > +                        SUN8I_I2S_FMT0_LRCLK_POLARITY_MASK |
> > +                        SUN8I_I2S_FMT0_BCLK_POLARITY_MASK,
> > +                        val);
> > +
> > +     /* DAI Mode */
> > +     switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > +     case SND_SOC_DAIFMT_DSP_A:
> > +             mode = SUN8I_I2S_CTRL_MODE_PCM;
> > +             offset = 1;
> > +             break;
> > +
> > +     case SND_SOC_DAIFMT_DSP_B:
> > +             mode = SUN8I_I2S_CTRL_MODE_PCM;
> > +             offset = 0;
> > +             break;
> > +
> > +     case SND_SOC_DAIFMT_I2S:
> > +             mode = SUN8I_I2S_CTRL_MODE_LEFT;
> > +             offset = 1;
> > +             break;
> > +
> > +     case SND_SOC_DAIFMT_LEFT_J:
> > +             mode = SUN8I_I2S_CTRL_MODE_LEFT;
> > +             offset = 0;
> > +             break;
> > +
> > +     case SND_SOC_DAIFMT_RIGHT_J:
> > +             mode = SUN8I_I2S_CTRL_MODE_RIGHT;
> > +             offset = 0;
> > +             break;
> > +
> > +     default:
> > +             return -EINVAL;
> > +     }
> > +
> > +     regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > +                        SUN8I_I2S_CTRL_MODE_MASK, mode);
> > +     regmap_update_bits(i2s->regmap, SUN8I_I2S_TX_CHAN_SEL_REG,
> > +                        SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET_MASK,
> > +                        SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET(offset));
> > +     regmap_update_bits(i2s->regmap, SUN50I_H6_I2S_RX_CHAN_SEL_REG,
> > +                        SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET_MASK,
> > +                        SUN50I_H6_I2S_TX_CHAN_SEL_OFFSET(offset));
> > +
> > +     /* DAI clock master masks */
> > +     switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> > +     case SND_SOC_DAIFMT_CBS_CFS:
> > +             /* BCLK and LRCLK master */
> > +             val = SUN8I_I2S_CTRL_BCLK_OUT | SUN8I_I2S_CTRL_LRCK_OUT;
> > +             break;
> > +
> > +     case SND_SOC_DAIFMT_CBM_CFM:
> > +             /* BCLK and LRCLK slave */
> > +             val = 0;
> > +             break;
> > +
> > +     default:
> > +             return -EINVAL;
> > +     }
> > +
> > +     regmap_update_bits(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > +                        SUN8I_I2S_CTRL_BCLK_OUT | SUN8I_I2S_CTRL_LRCK_OUT,
> > +                        val);
> > +
> > +     return 0;
> > +}
> > +
> >  static int sun4i_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> >  {
> >       struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
> ...