linux-kernel - [PATCH v2 28/32] auxdisplay: hd44780: Remove clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200921144645.2061313-29-poeschel@lemonage.de>
Date:   Mon, 21 Sep 2020 16:46:40 +0200
From:   poeschel@...onage.de
To:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        linux-kernel@...r.kernel.org (open list)
Cc:     Lars Poeschel <poeschel@...onage.de>
Subject: [PATCH v2 28/32] auxdisplay: hd44780: Remove clear_fast

From: Lars Poeschel <poeschel@...onage.de>

We remove the hd44780_clear_fast (display) clear implementation. charlcd
will fall back to use hd44780_common_clear_display then, which is much
much faster.

Signed-off-by: Lars Poeschel <poeschel@...onage.de>
---
 drivers/auxdisplay/hd44780.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 207ed23e02ce..2e5e7c993933 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -38,18 +38,6 @@ struct hd44780 {
 	struct gpio_desc *pins[PIN_NUM];
 };
 
-static void hd44780_clear_fast(struct charlcd *lcd)
-{
-	struct hd44780_common *hdc = lcd->drvdata;
-	int pos;
-
-	hd44780_common_home(lcd);
-	for (pos = 0; pos < min(2, lcd->height) * hdc->hwidth; pos++)
-		hd44780_common_print(lcd, ' ');
-
-	hd44780_common_home(lcd);
-}
-
 static void hd44780_backlight(struct charlcd *lcd, enum charlcd_onoff on)
 {
 	struct hd44780_common *hdc = lcd->drvdata;
@@ -137,7 +125,6 @@ static void hd44780_write_data_gpio8(struct hd44780_common *hdc, int data)
 }
 
 static const struct charlcd_ops hd44780_ops_gpio8 = {
-	.clear_fast	= hd44780_clear_fast,
 	.backlight	= hd44780_backlight,
 	.print		= hd44780_common_print,
 	.gotoxy		= hd44780_common_gotoxy,
@@ -194,7 +181,6 @@ static void hd44780_write_data_gpio4(struct hd44780_common *hdc, int data)
 }
 
 static const struct charlcd_ops hd44780_ops_gpio4 = {
-	.clear_fast	= hd44780_clear_fast,
 	.backlight	= hd44780_backlight,
 	.print		= hd44780_common_print,
 	.gotoxy		= hd44780_common_gotoxy,
-- 
2.28.0