linux-kernel - Re: [PATCH -next] phy: fix USB_LGM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb3b277e-109d-82c5-9dec-153b4e035c2a@infradead.org>
Date:   Mon, 21 Sep 2020 08:45:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>
Cc:     Li Yin <yin1.li@...el.com>,
        Vadivel Murugan R <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors

Ping.  Still seeing this in linux-next.

On 9/17/20 10:51 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix a Kconfig warning that is causing lots of build errors
> when USB_SUPPORT is not set.
> 
> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
> dependencies, so this driver should also depend on USB_SUPPORT.
> It should not select USB_SUPPORT.
> 
> WARNING: unmet direct dependencies detected for USB_PHY
>   Depends on [n]: USB_SUPPORT [=n]
>   Selected by [m]:
>   - USB_LGM_PHY [=m]
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Li Yin <yin1.li@...el.com>
> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@...ux.intel.com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Vinod Koul <vkoul@...nel.org>
> ---
>  drivers/phy/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20200917.orig/drivers/phy/Kconfig
> +++ linux-next-20200917/drivers/phy/Kconfig
> @@ -51,6 +51,7 @@ config PHY_XGENE
>  
>  config USB_LGM_PHY
>  	tristate "INTEL Lightning Mountain USB PHY Driver"
> +	depends on USB_SUPPORT
>  	select USB_PHY
>  	select REGULATOR
>  	select REGULATOR_FIXED_VOLTAGE
> 


-- 
~Randy