linux-kernel - Re: [RFC PATCH] mm/page_alloc.c: clean code by merging two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921155837.GH3179@techsingularity.net>
Date:   Mon, 21 Sep 2020 16:58:37 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     mateusznosek0@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RFC PATCH] mm/page_alloc.c: clean code by merging two functions

On Mon, Sep 21, 2020 at 03:36:07PM +0300, Mike Rapoport wrote:
> Hi,
> 
> (added Mel)
> 
> On Wed, Sep 16, 2020 at 01:01:18PM +0200, mateusznosek0@...il.com wrote:
> > From: Mateusz Nosek <mateusznosek0@...il.com>
> > 
> > The 'finalise_ac' function is just 'epilogue' for 'prepare_alloc_pages'.
> > Therefore there is no need to keep them both so 'finalise_ac' content can
> > be merged into 'prepare_alloc_pages' code. It would make
> > '__alloc_pages_nodemask' cleaner when it comes to readability.
> 
> These functions were split from alloc_pages_nodemask() by commit
> 9cd7555875bb ("mm, page_alloc: split alloc_pages_nodemask()"), so at the
> very least I'd add Mel to 'cc. 
> 

The changelog explains the intent. At the time, there was demand for a
bulk page allocator for networking support and one was prototyped
https://lore.kernel.org/lkml/20170109163518.6001-5-mgorman@techsingularity.net/
but the networking side to consume the interface was never finished.

-- 
Mel Gorman
SUSE Labs