lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Sep 2020 18:23:35 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Pavel Machek <pavel@....cz>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Tianshu Qiu <tian.shu.qiu@...el.com>, Dongchun Zhu <dongchun.zhu@...iatek.com>, Shawn Tu <shawnx.tu@...el.com>, Ricardo Ribalda <ribalda@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Bingbu Cao <bingbu.cao@...el.com>, Rui Miguel Silva <rmfrfs@...il.com>, Shunqian Zheng <zhengsq@...k-chips.com>, Chiranjeevi Rapolu <chiranjeevi.rapolu@...el.com>, Hyungwoo Yang <hyungwoo.yang@...el.com>, Wenyou Yang <wenyou.yang@...rochip.com>, Hans Verkuil <hverkuil-cisco@...all.nl>, Marco Felsch <m.felsch@...gutronix.de>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Krzysztof Kozlowski <krzk@...nel.org> Subject: [PATCH 18/25] media: i2c: ov2740: simplify getting state container The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> --- drivers/media/i2c/ov2740.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index bd0d45b0d43f..0d32b0c0ca11 100644 --- a/drivers/media/i2c/ov2740.c +++ b/drivers/media/i2c/ov2740.c @@ -674,8 +674,7 @@ static int ov2740_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused ov2740_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); mutex_lock(&ov2740->mutex); @@ -689,8 +688,7 @@ static int __maybe_unused ov2740_suspend(struct device *dev) static int __maybe_unused ov2740_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); int ret = 0; -- 2.17.1
Powered by blists - more mailing lists