linux-kernel - Re: [PATCH -next] sound: use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8sd3nkzn.wl-tiwai@suse.de>
Date:   Mon, 21 Sep 2020 18:38:20 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Qilong Zhang <zhangqilong3@...wei.com>
Cc:     <peter.ujfalusi@...com>, <perex@...ex.cz>, <tiwai@...e.com>,
        <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] sound: use devm_platform_ioremap_resource_byname

On Wed, 16 Sep 2020 13:11:22 +0200,
Qilong Zhang wrote:
> 
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Zhang Qilong <zhangqilong3@...wei.com>
> ---
>  sound/soc/ti/omap-mcbsp.c | 6 +-----

This is an ASoC stuff, and should be submitted to the proper
maintainer (Mark).  Also please use the subject prefix matching
with the target subsystem.  In this case, it should be
"ASoC: xxx".


thanks,

Takashi

>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c
> index 6025b30bbe77..186cea91076f 100644
> --- a/sound/soc/ti/omap-mcbsp.c
> +++ b/sound/soc/ti/omap-mcbsp.c
> @@ -620,11 +620,7 @@ static int omap_mcbsp_init(struct platform_device *pdev)
>  	spin_lock_init(&mcbsp->lock);
>  	mcbsp->free = true;
>  
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpu");
> -	if (!res)
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	mcbsp->io_base = devm_ioremap_resource(&pdev->dev, res);
> +	mcbsp->io_base = devm_platform_ioremap_resource_byname(pdev, "mpu");
>  	if (IS_ERR(mcbsp->io_base))
>  		return PTR_ERR(mcbsp->io_base);
>  
> -- 
> 2.17.1
>