linux-kernel - Re: [PATCH v1 3/3] clk: qcom: camcc: Add camera clock controller driver for SC7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 03:03:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Taniya Das <tdas@...eaurora.org>, Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette   
        <mturquette@...libre.com>
Cc:     kbuild-all@...ts.01.org, David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 3/3] clk: qcom: camcc: Add camera clock controller
 driver for SC7180

Hi Taniya,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v5.9-rc6 next-20200921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Taniya-Das/clk-qcom-clk-alpha-pll-Add-support-for-controlling-Agera-PLLs/20200909-011101
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: h8300-allyesconfig (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/clk/qcom/camcc-sc7180.c:36:2: warning: this decimal constant is unsigned only in ISO C90
      36 |  { 600000000, 3300000000, 0 },
         |  ^
   drivers/clk/qcom/camcc-sc7180.c: In function 'cam_cc_sc7180_probe':
>> drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function 'pm_clk_runtime_resume'; did you mean 'pm_runtime_resume'? [-Werror=implicit-function-declaration]
    1672 |  ret = pm_clk_runtime_resume(&pdev->dev);
         |        ^~~~~~~~~~~~~~~~~~~~~
         |        pm_runtime_resume
>> drivers/clk/qcom/camcc-sc7180.c:1696:8: error: implicit declaration of function 'pm_clk_runtime_suspend'; did you mean 'pm_runtime_suspend'? [-Werror=implicit-function-declaration]
    1696 |  ret = pm_clk_runtime_suspend(&pdev->dev);
         |        ^~~~~~~~~~~~~~~~~~~~~~
         |        pm_runtime_suspend
   cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/05a7fc252efe1fcdd278d22893ea689d8b5f1f1e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Taniya-Das/clk-qcom-clk-alpha-pll-Add-support-for-controlling-Agera-PLLs/20200909-011101
git checkout 05a7fc252efe1fcdd278d22893ea689d8b5f1f1e
vim +1672 drivers/clk/qcom/camcc-sc7180.c

  1649	
  1650	static int cam_cc_sc7180_probe(struct platform_device *pdev)
  1651	{
  1652		struct regmap *regmap;
  1653		int ret;
  1654	
  1655		pm_runtime_enable(&pdev->dev);
  1656		ret = pm_clk_create(&pdev->dev);
  1657		if (ret)
  1658			return ret;
  1659	
  1660		ret = pm_clk_add(&pdev->dev, "xo");
  1661		if (ret < 0) {
  1662			dev_err(&pdev->dev, "Failed to acquire XO clock\n");
  1663			goto disable_pm_runtime;
  1664		}
  1665	
  1666		ret = pm_clk_add(&pdev->dev, "iface");
  1667		if (ret < 0) {
  1668			dev_err(&pdev->dev, "Failed to acquire iface clock\n");
  1669			goto disable_pm_runtime;
  1670		}
  1671	
> 1672		ret = pm_clk_runtime_resume(&pdev->dev);
  1673		if (ret) {
  1674			dev_err(&pdev->dev, "pm runtime resume failed\n");
  1675			goto destroy_pm_clk;
  1676		}
  1677	
  1678		regmap = qcom_cc_map(pdev, &cam_cc_sc7180_desc);
  1679		if (IS_ERR(regmap)) {
  1680			ret = PTR_ERR(regmap);
  1681			goto destroy_pm_clk;
  1682		}
  1683	
  1684		clk_fabia_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config);
  1685		clk_fabia_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config);
  1686		clk_agera_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config);
  1687		clk_fabia_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config);
  1688	
  1689		ret = qcom_cc_really_probe(pdev, &cam_cc_sc7180_desc, regmap);
  1690		if (ret) {
  1691			dev_err(&pdev->dev, "Failed to register CAM CC clocks\n");
  1692			goto suspend_pm_runtime;
  1693		}
  1694	
  1695	suspend_pm_runtime:
> 1696		ret = pm_clk_runtime_suspend(&pdev->dev);
  1697		if (ret)
  1698			dev_err(&pdev->dev, "pm runtime suspend failed\n");
  1699	
  1700		return 0;
  1701	
  1702	destroy_pm_clk:
  1703		pm_clk_destroy(&pdev->dev);
  1704	
  1705	disable_pm_runtime:
  1706		pm_runtime_disable(&pdev->dev);
  1707	
  1708		return ret;
  1709	}
  1710	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (56305 bytes)