linux-kernel - Re: [PATCH v1 ] drm/amd/pm: Removed fixed clock in auto mode DPM

Open Source and information security mailing list archives

Message-ID: <CADnq5_NWnMraD_WPoms0G-bqmNxf7tN86h34Dm1Z+6ZTeqqzNg@mail.gmail.com>
Date:   Mon, 21 Sep 2020 15:55:00 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Sudheesh Mavila <sudheesh.mavila@....com>,
        "Quan, Evan" <evan.quan@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>,
        zhengbin <zhengbin13@...wei.com>,
        Jason Yan <yanaijie@...wei.com>,
        Tom St Denis <tom.stdenis@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v1 ] drm/amd/pm: Removed fixed clock in auto mode DPM

Applied with fixed up whitespace.

Thanks,

Alex

On Tue, Sep 15, 2020 at 3:45 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 15.09.20 um 09:18 schrieb Sudheesh Mavila:
> >      SMU10_UMD_PSTATE_PEAK_FCLK value should not be used to set the DPM.
> >
> >      Change  suggested by Evan.Quan@....com
>
> Can't say much about the change itself, but the Commit message is
> indented and the indentation in the code doesn't look consistent either.
>
> Christian.
>
> >
> > Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> > ---
> >   drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 10 ++++++----
> >   1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
> > index c9cfe90a2947..081cb9b1b7c8 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
> > @@ -566,6 +566,8 @@ static int smu10_dpm_force_dpm_level(struct pp_hwmgr *hwmgr,
> >       struct smu10_hwmgr *data = hwmgr->backend;
> >       uint32_t min_sclk = hwmgr->display_config->min_core_set_clock;
> >       uint32_t min_mclk = hwmgr->display_config->min_mem_set_clock/100;
> > +     uint32_t index_fclk = data->clock_vol_info.vdd_dep_on_fclk->count - 1;
> > +     uint32_t index_socclk = data->clock_vol_info.vdd_dep_on_socclk->count - 1;
> >
> >       if (hwmgr->smu_version < 0x1E3700) {
> >               pr_info("smu firmware version too old, can not set dpm level\n");
> > @@ -679,13 +681,13 @@ static int smu10_dpm_force_dpm_level(struct pp_hwmgr *hwmgr,
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetHardMinFclkByFreq,
> >                                               hwmgr->display_config->num_display > 3 ?
> > -                                             SMU10_UMD_PSTATE_PEAK_FCLK :
> > +                                     data->clock_vol_info.vdd_dep_on_fclk->entries[0].clk :
> >                                               min_mclk,
> >                                               NULL);
> >
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetHardMinSocclkByFreq,
> > -                                             SMU10_UMD_PSTATE_MIN_SOCCLK,
> > +                                     data->clock_vol_info.vdd_dep_on_socclk->entries[0].clk,
> >                                               NULL);
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetHardMinVcn,
> > @@ -698,11 +700,11 @@ static int smu10_dpm_force_dpm_level(struct pp_hwmgr *hwmgr,
> >                                               NULL);
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetSoftMaxFclkByFreq,
> > -                                             SMU10_UMD_PSTATE_PEAK_FCLK,
> > +                             data->clock_vol_info.vdd_dep_on_fclk->entries[index_fclk].clk,
> >                                               NULL);
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetSoftMaxSocclkByFreq,
> > -                                             SMU10_UMD_PSTATE_PEAK_SOCCLK,
> > +                             data->clock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk,
> >                                               NULL);
> >               smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                               PPSMC_MSG_SetSoftMaxVcn,
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives