linux-kernel - Re: [PATCH v2] PCI: brcmstb: Add missing if statement and error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97332b07-6496-ff46-9f05-fda12220264b@gmail.com>
Date:   Mon, 21 Sep 2020 14:21:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Jim Quinlan <jquinlan@...adcom.com>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: brcmstb: Add missing if statement and error path

On 9/21/20 2:16 PM, Alex Dewar wrote:
> brcm_pcie_resume() contains a return statement that was presumably
> intended to have an "if (ret)" in front of it, otherwise the function
> returns prematurely. Fix this.
> 
> Additionally, redisable the clock on the error path.
> 
> I don't know if this code was tested or not, but I assume that this bug
> means that this driver will not resume properly.
> 
> Fixes: ad3d29c77e1e ("PCI: brcmstb: Add control of rescal reset")
> Addresses-Coverity: CID 1497099: Control flow issues (UNREACHABLE)
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> ---
You need to coordinate with Colin, or with whomever is looking at
Coverity defects, because he just submitted a similar patch minutes ago:

https://lore.kernel.org/linux-arm-kernel/20200921211555.383458-1-colin.king@canonical.com/
-- 
Florian