linux-kernel - Re: [PATCH 1/4] s390/pci: stash version in the zpci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2182380c-44f6-edcb-03a0-2af79a16536c@de.ibm.com>
Date:   Mon, 21 Sep 2020 11:38:01 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Matthew Rosato <mjrosato@...ux.ibm.com>,
        alex.williamson@...hat.com, cohuck@...hat.com,
        schnelle@...ux.ibm.com
Cc:     pmorel@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] s390/pci: stash version in the zpci_dev

On 19.09.20 17:28, Matthew Rosato wrote:
> In preparation for passing the info on to vfio-pci devices, stash the
> supported PCI version for the target device in the zpci_dev.
> 
> Signed-off-by: Matthew Rosato <mjrosato@...ux.ibm.com>

In case this will go via the vfio tree, with my s390 kernel maintainer hat on:

Acked-by: Christian Borntraeger <borntraeger@...ibm.com>
> ---
>  arch/s390/include/asm/pci.h | 1 +
>  arch/s390/pci/pci_clp.c     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
> index 99b92c3..882e233 100644
> --- a/arch/s390/include/asm/pci.h
> +++ b/arch/s390/include/asm/pci.h
> @@ -179,6 +179,7 @@ struct zpci_dev {
>  	atomic64_t mapped_pages;
>  	atomic64_t unmapped_pages;
>  
> +	u8		version;
>  	enum pci_bus_speed max_bus_speed;
>  
>  	struct dentry	*debugfs_dev;
> diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c
> index 7e735f4..48bf316 100644
> --- a/arch/s390/pci/pci_clp.c
> +++ b/arch/s390/pci/pci_clp.c
> @@ -102,6 +102,7 @@ static void clp_store_query_pci_fngrp(struct zpci_dev *zdev,
>  	zdev->msi_addr = response->msia;
>  	zdev->max_msi = response->noi;
>  	zdev->fmb_update = response->mui;
> +	zdev->version = response->version;
>  
>  	switch (response->version) {
>  	case 1:
>