linux-kernel - Re: [PATCH 3/3] i2c: jz4780: Remove of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200921094241.GK1840@ninjato>
Date:   Mon, 21 Sep 2020 11:42:41 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Paul Cercueil <paul@...pouillou.net>, od@...c.me,
        Linux I2C <linux-i2c@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()


> Indeed, because jz4780_i2c_of_matches isn't within a CONFIG_OF ifdef
> as is sometimes done and is when you need of_match_ptr(). IMO, the
> commit msg should have something like "The driver is only used with
> CONFIG_OF enabled, so of_match_ptr() is not necessary.
> jz4780_i2c_of_matches is always defined."

I think the commit message says that good enough.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)