linux-kernel - Re: [PATCH v2] checkpatch: extend author Signed-off-by check for split From: header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <984edba5dae45d5b5a9b8381f6164423380037d7.camel@perches.com>
Date:   Mon, 21 Sep 2020 02:47:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        linux-kernel-mentees@...ts.linuxfoundation.org, apw@...onical.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: extend author Signed-off-by check for
 split From: header

On Mon, 2020-09-21 at 09:39 +0200, Lukas Bulwahn wrote:
> On Sun, 20 Sep 2020, Joe Perches wrote:
> > On Sun, 2020-09-20 at 21:52 +0530, Dwaipayan Ray wrote:
[]
> > > For example, Lukas checked commits between v5.4 and
> > > v5.8 and he found:
> > >     175 Missing Signed-off-by: line by nominal patch authorrep
> > >     'Daniel Vetter <daniel.vetter@...ll.ch>'
> > > 
> > > Infact in all of those commits he signed off using a different
> > > mail, Daniel Vetter <daniel.vetter@...el.com>.
> > > 
> > > So is it possible to resolve these using perhaps .mailmap
> > > entries? Or should only the name mismatch part be better
> > > handled? Or perhaps both?
> > 
> > Dunno.  It certainly can be improved...
> > Try adding some more logic and see what you come up with.
> > 
> > btw:
> > 
> > The most frequent NO_AUTHOR_SIGN_OFF messages for v5.7..v5.8 are
> > 
> >      98 WARNING: From:/SoB: email address mismatch: 'From: Daniel Vetter <daniel.vetter@...ll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>'
> >      24 WARNING: From:/SoB: email address mismatch: 'From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>' != 'Signed-off-by: Thinh Nguyen <thinhn@...opsys.com>'
> >      19 WARNING: From:/SoB: email address mismatch: 'From: Wolfram Sang <wsa+renesas@...g-engineering.com>' != 'Signed-off-by: Wolfram Sang <wsa@...nel.org>'
> >      11 WARNING: From:/SoB: email address mismatch: 'From: Luke Nelson <lukenels@...washington.edu>' != 'Signed-off-by: Luke Nelson <luke.r.nels@...il.com>'
> >       8 WARNING: From:/SoB: email address mismatch: 'From: Christophe Leroy <christophe.leroy@....fr>' != 'Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>'
> >       6 WARNING: From:/SoB: email address mismatch: 'From: Davidlohr Bueso <dave@...olabs.net>' != 'Signed-off-by: Davidlohr Bueso <dbueso@...e.de>'
> >       5 WARNING: Missing Signed-off-by: line by nominal patch author '"Paul A. Clarke" <pc@...ibm.com>'
> >       4 WARNING: Missing Signed-off-by: line by nominal patch author 'Huang Ying <ying.huang@...el.com>'
> >       3 WARNING: Missing Signed-off-by: line by nominal patch author '"Stephan Müller" <smueller@...onox.de>'
[]
> I hope Dwaipayan can come up with a '.AUTHOR_SIGN_OFF.mailmap' file that 
> we can use to distinguish the known developers that knowingly and 
> intentionally use different identities vs. the 'newbies' that should 
> validly be warned.

I hope not.  One .mailmap should be enough.