linux-kernel - Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Sep 2020 13:59:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     gregkh@...uxfoundation.org, laurent.pinchart@...net.be,
        mchehab@...nel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough
 keyword

On Mon, Sep 21, 2020 at 10:20:12AM +0000, Corentin Labbe wrote:
> This patch adds fallthrough keyword where appropriate.
> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  drivers/staging/media/zoran/zoran_device.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
> index 9558bafdde7d..7634d94f9359 100644
> --- a/drivers/staging/media/zoran/zoran_device.c
> +++ b/drivers/staging/media/zoran/zoran_device.c
> @@ -268,7 +268,9 @@ static void zr36057_adjust_vfe(struct zoran *zr, enum zoran_codec_mode mode)
>  		btwrite(reg, ZR36057_VFEHCR);
>  		break;
>  	case BUZ_MODE_MOTION_COMPRESS:
> +		fallthrough;
>  	case BUZ_MODE_IDLE:
> +		fallthrough;
>  	default:

Hopefully, we don't need fallthrough labels for empty switch statements
like this?

regards,
dan carpenter