linux-kernel - Re: [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921113143.GD2139@willie-the-truck>
Date:   Mon, 21 Sep 2020 12:31:43 +0100
From:   Will Deacon <will@...nel.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     ardb@...nel.org, keescook@...omium.org, mingo@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: fix incomplete comment in
 refcount_dec_and_lock_irqsave()

On Mon, Sep 21, 2020 at 07:23:58AM -0400, Miaohe Lin wrote:
> The description of arg flags is incomplete. The flags is saved IRQ-flags
> when the @lock is acquired.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  lib/refcount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/refcount.c b/lib/refcount.c
> index ebac8b7d15a7..dcfd092f66c7 100644
> --- a/lib/refcount.c
> +++ b/lib/refcount.c
> @@ -161,7 +161,7 @@ EXPORT_SYMBOL(refcount_dec_and_lock);
>   *                                 interrupts if able to decrement refcount to 0
>   * @r: the refcount
>   * @lock: the spinlock to be locked
> - * @flags: saved IRQ-flags if the is acquired
> + * @flags: saved IRQ-flags if the is @lock acquired

This still isn't quite right. If we go with:

  @flags: saved IRQ-flags if @lock is acquired

then:

Acked-by: Will Deacon <will@...nel.org>

Will