linux-kernel - Re: [PATCH v2] lib: fix incomplete comment in refcount_dec_and_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4a6ab26488c143259d0f04ff636fe6f3@huawei.com>
Date:   Mon, 21 Sep 2020 11:41:35 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Will Deacon <will@...nel.org>
CC:     "ardb@...nel.org" <ardb@...nel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] lib: fix incomplete comment in
 refcount_dec_and_lock_irqsave()

Will Deacon <will@...nel.org> wrote:
> On Mon, Sep 21, 2020 at 07:23:58AM -0400, Miaohe Lin wrote:
>> The description of arg flags is incomplete. The flags is saved 
>> IRQ-flags when the @lock is acquired.
>> 
>> + * @flags: saved IRQ-flags if the is @lock acquired
>
>This still isn't quite right. If we go with:
>
>  @flags: saved IRQ-flags if @lock is acquired
>

This is what I mean to do... Sorry for this overlook.

>then:
>
>Acked-by: Will Deacon <will@...nel.org>
>
>Will

Thanks for acked-by tag and kindly reply.