linux-kernel - Re: PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Sep 2020 20:50:14 -0700
From:   Robert Gadsdon <rhgadsdon@...il.com>
To:     Stuart Little <achirvasub@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>, linux-nvdimm@...ts.01.org
Cc:     kernel list <linux-kernel@...r.kernel.org>
Subject: Re: PROBLEM: 5.9.0-rc6 fails to compile due to 'redefinition of ‘dax_supported’'


On 9/20/20 7:25 PM, Stuart Little wrote:
> An update on this: I've done a bisect, with the following result.
>
> --- cut here ---
>
> e2ec5128254518cae320d5dc631b71b94160f663 is the first bad commit
> commit e2ec5128254518cae320d5dc631b71b94160f663
> Author: Jan Kara <jack@...e.cz>
> Date:   Sun Sep 20 08:54:42 2020 -0700
>
>      dm: Call proper helper to determine dax support
>      
>      DM was calling generic_fsdax_supported() to determine whether a device
>      referenced in the DM table supports DAX. However this is a helper for "leaf" device drivers so that
>      they don't have to duplicate common generic checks. High level code
>      should call dax_supported() helper which that calls into appropriate
>      helper for the particular device. This problem manifested itself as
>      kernel messages:
>      
>      dm-3: error: dax access failed (-95)
>      
>      when lvm2-testsuite run in cases where a DM device was stacked on top of
>      another DM device.
>      
>      Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple devices")
>      Cc: <stable@...r.kernel.org>
>      Tested-by: Adrian Huang <ahuang12@...ovo.com>
>      Signed-off-by: Jan Kara <jack@...e.cz>
>      Acked-by: Mike Snitzer <snitzer@...hat.com>
>      Reported-by: kernel test robot <lkp@...el.com>
>      Link: https://lore.kernel.org/r/160061715195.13131.5503173247632041975.stgit@dwillia2-desk3.amr.corp.intel.com
>      Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>
>   drivers/dax/super.c   |  4 ++++
>   drivers/md/dm-table.c | 10 +++++++---
>   include/linux/dax.h   | 22 ++++++++++++++++++++--
>   3 files changed, 31 insertions(+), 5 deletions(-)
>
> --- end ---
>
Confirm that reverting this patch, 5.9-rc6 compiles OK ...

RG.