linux-kernel - Re: [PATCH v6 7/7] perf diff: Support hot streams comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921121700.GH1996959@kernel.org>
Date:   Mon, 21 Sep 2020 09:17:00 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v6 7/7] perf diff: Support hot streams comparison

Em Sat, Sep 19, 2020 at 12:41:35PM +0800, Jin, Yao escreveu:
> Hi Arnaldo,
> 
> On 9/18/2020 4:26 AM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Sep 11, 2020 at 04:03:53PM +0800, Jin Yao escreveu:
> > > This patch enables perf-diff with "--stream" option.
> > > 
> > > "--stream": Enable hot streams comparison
> > > 
> > > Now let's see examples.
> > > 
> > > perf record -b ...      Generate perf.data.old with branch data
> > > perf record -b ...      Generate perf.data with branch data
> > > perf diff --stream
> > > 
> > > [ Matched hot streams ]
> > > 
> > > hot chain pair 1:
> > >              cycles: 1, hits: 27.77%                  cycles: 1, hits: 9.24%
> > >          ---------------------------              --------------------------
> > >                        main div.c:39                           main div.c:39
> > >                        main div.c:44                           main div.c:44
> > > 
> > > hot chain pair 2:
> > >             cycles: 34, hits: 20.06%                cycles: 27, hits: 16.98%
> > >          ---------------------------              --------------------------
> > >            __random_r random_r.c:360               __random_r random_r.c:360
> > 
> > Would it be interesting to get the associated source code and show right below
> > these file:number lines?
> > 
> > - Arnaldo
> > 
> 
> I'm thinking we can implement this function in callchain_list__sym_name(),
> and then all callchain functionality will benefit from it. While that looks
> to be another patchset. :)

Sure, after we go thru the process of merging the current one.
 
> Thanks
> Jin Yao

-- 

- Arnaldo