linux-kernel - Re: [PATCH] wireless: ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200921130558.F092DC43385@smtp.codeaurora.org>
Date:   Mon, 21 Sep 2020 13:05:58 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brooke Basile <brookebasile@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, gregkh@...uxfoundation.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath9k-devel@....qualcomm.com, syzkaller-bugs@...glegroups.com,
        Brooke Basile <brookebasile@...il.com>,
        syzbot+89bd486af9427a9fc605@...kaller.appspotmail.com
Subject: Re: [PATCH] wireless: ath9k: hif_usb: fix race condition between
 usb_get_urb() and usb_kill_anchored_urbs()

Brooke Basile <brookebasile@...il.com> wrote:

> Calls to usb_kill_anchored_urbs() after usb_kill_urb() on multiprocessor
> systems create a race condition in which usb_kill_anchored_urbs() deallocates
> the URB before the completer callback is called in usb_kill_urb(), resulting
> in a use-after-free.
> To fix this, add proper lock protection to usb_kill_urb() calls that can
> possibly run concurrently with usb_kill_anchored_urbs().
> 
> Reported-by: syzbot+89bd486af9427a9fc605@...kaller.appspotmail.com
> Link: https://syzkaller.appspot.com/bug?id=cabffad18eb74197f84871802fd2c5117b61febf
> Signed-off-by: Brooke Basile <brookebasile@...il.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

03fb92a432ea ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()

-- 
https://patchwork.kernel.org/patch/11769845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches