linux-kernel - Re: [PATCH] ath11k: Mark two variables as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zh5j45oj.fsf@codeaurora.org>
Date:   Mon, 21 Sep 2020 16:31:40 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <davem@...emloft.net>, <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath11k: Mark two variables as __maybe_unused

YueHaibing <yuehaibing@...wei.com> writes:

> Fix -Wunused-variable warnings:
>
> drivers/net/wireless/ath/ath11k/debug.c:36:20: warning: ‘htt_bp_lmac_ring’ defined but not used [-Wunused-variable]
> drivers/net/wireless/ath/ath11k/debug.c:15:20: warning: ‘htt_bp_umac_ring’ defined but not used [-Wunused-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

I don't like __maybe_unused so I decided to fix this with some refactoring:

[1/4] ath11k: refactor debugfs code into debugfs.c
https://patchwork.kernel.org/patch/11781017/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches