linux-kernel - Re: [PATCH -next] virt: vbox: simplify the return expression of vbg_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cced541-88ab-bb21-6fc4-e6c06d2d2260@redhat.com>
Date:   Mon, 21 Sep 2020 15:33:59 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Qinglang Miao <miaoqinglang@...wei.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] virt: vbox: simplify the return expression of
 vbg_input_open()

Hi,

On 9/21/20 3:11 PM, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>

Thank you, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/virt/vboxguest/vboxguest_linux.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 6215a688e..73eb34849 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -202,13 +202,8 @@ static int vbg_input_open(struct input_dev *input)
>   {
>   	struct vbg_dev *gdev = input_get_drvdata(input);
>   	u32 feat = VMMDEV_MOUSE_GUEST_CAN_ABSOLUTE | VMMDEV_MOUSE_NEW_PROTOCOL;
> -	int ret;
>   
> -	ret = vbg_core_set_mouse_status(gdev, feat);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return vbg_core_set_mouse_status(gdev, feat);
>   }
>   
>   /**
>