linux-kernel - Re: [PATCH v2] powercap: include header to fix -Wmissing-prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Sep 2020 16:05:19 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Herrington <hankinsea@...il.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        shipujin.t@...il.com, Pujin Shi <shipj@...ote.com>
Subject: Re: [PATCH v2] powercap: include header to fix -Wmissing-prototypes

On Mon, Sep 21, 2020 at 9:04 AM Herrington <hankinsea@...il.com> wrote:
>
> Include the linux/idle_inject.h header to fix W=1 build warning:
>
>     drivers/powercap/idle_inject.c:152:6: warning: no previous prototype for ‘idle_inject_set_duration’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:167:6: warning: no previous prototype for ‘idle_inject_get_duration’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:179:6: warning: no previous prototype for ‘idle_inject_set_latency’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:195:5: warning: no previous prototype for ‘idle_inject_start’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:227:6: warning: no previous prototype for ‘idle_inject_stop’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:299:28: warning: no previous prototype for ‘idle_inject_register’ [-Wmissing-prototypes]
>     drivers/powercap/idle_inject.c:345:6: warning: no previous prototype for ‘idle_inject_unregister’ [-Wmissing-prototypes]
>
> Signed-off-by: Herrington <hankinsea@...il.com>
> Signed-off-by: Pujin Shi <shipujin.t@...il.com>
> Signed-off-by: Pujin Shi <shipj@...ote.com>

First, who is the other person whose S-o-b is present here?  For a
co-author of the patch, a Co-developed-by tag should be present too.
Otherwise, a Reviewed-by tag should be used instead of the S-o-b.

Also, one S-o-b (or R-by) per developer would be sufficient.

> ---
>  drivers/powercap/idle_inject.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
> index 4310901a074e..6e1a0043c411 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -43,6 +43,7 @@
>  #include <linux/sched.h>
>  #include <linux/slab.h>
>  #include <linux/smpboot.h>
> +#include <linux/idle_inject.h>
>
>  #include <uapi/linux/sched/types.h>
>
> --
> 2.25.4
>