linux-kernel - Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Sep 2020 19:37:13 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     bbhatt@...eaurora.org
Cc:     Jeffrey Hugo <jhugo@...eaurora.org>, linux-arm-msm@...r.kernel.org,
        hemantk@...eaurora.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing
 MODULE_LICENSE()

On Fri, Sep 18, 2020 at 11:48:21AM -0700, bbhatt@...eaurora.org wrote:
> On 2020-09-18 10:18, Manivannan Sadhasivam wrote:
> > On Fri, Sep 18, 2020 at 09:49:05AM -0700, bbhatt@...eaurora.org wrote:
> > > On 2020-09-18 07:27, Jeffrey Hugo wrote:
> > > > On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote:
> > > > > When building MHI as a module, missing MODULE_LICENSE() warnings
> > > > > are seen. Avoid them by adding the license and description
> > > > > information for the files where the warnings are seen.
> > > > >
> > > > > Signed-off-by: Bhaumik Bhatt <bbhatt@...eaurora.org>
> > > > > ---
> > > > >   drivers/bus/mhi/core/boot.c | 3 +++
> > > > >   drivers/bus/mhi/core/main.c | 3 +++
> > > > >   drivers/bus/mhi/core/pm.c   | 3 +++
> > > > >   3 files changed, 9 insertions(+)
> > > > >
> > > > > diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
> > > > > index 24422f5..78140cc 100644
> > > > > --- a/drivers/bus/mhi/core/boot.c
> > > > > +++ b/drivers/bus/mhi/core/boot.c
> > > > > @@ -523,3 +523,6 @@ void mhi_fw_load_handler(struct mhi_controller
> > > > > *mhi_cntrl)
> > > > >   error_alloc_fw_table:
> > > > >   	release_firmware(firmware);
> > > > >   }
> > > > > +
> > > > > +MODULE_LICENSE("GPL v2");
> > > > > +MODULE_DESCRIPTION("MHI Host Interface");
> > > > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> > > > > index 2cff5dd..172026f 100644
> > > > > --- a/drivers/bus/mhi/core/main.c
> > > > > +++ b/drivers/bus/mhi/core/main.c
> > > > > @@ -1533,3 +1533,6 @@ int mhi_poll(struct mhi_device *mhi_dev, u32
> > > > > budget)
> > > > >   	return ret;
> > > > >   }
> > > > >   EXPORT_SYMBOL_GPL(mhi_poll);
> > > > > +
> > > > > +MODULE_LICENSE("GPL v2");
> > > > > +MODULE_DESCRIPTION("MHI Host Interface");
> > > > > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> > > > > index ce4d969..72c3dbc 100644
> > > > > --- a/drivers/bus/mhi/core/pm.c
> > > > > +++ b/drivers/bus/mhi/core/pm.c
> > > > > @@ -1150,3 +1150,6 @@ void mhi_device_put(struct mhi_device *mhi_dev)
> > > > >   	read_unlock_bh(&mhi_cntrl->pm_lock);
> > > > >   }
> > > > >   EXPORT_SYMBOL_GPL(mhi_device_put);
> > > > > +
> > > > > +MODULE_LICENSE("GPL v2");
> > > > > +MODULE_DESCRIPTION("MHI Host Interface");
> > > > >
> > > >
> > > > I would expect you only need to add the MODULE_* once per module, in
> > > > which case main.c is probably the only place that needs it.
> > > 
> > > Hi Jeff,
> > > 
> > > I thought so too. This is to fix below warnings seen when building
> > > MHI as a
> > > MODULE:
> > > 
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/bus/mhi/core/main.o
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/bus/mhi/core/pm.o
> > > WARNING: modpost: missing MODULE_LICENSE() in
> > > drivers/bus/mhi/core/boot.o
> > > 
> > > We've only had those in init.c so far.
> > > 
> > 
> > Can you please test below diff to see if it fixes the warning?
> > 
> > diff --git a/drivers/bus/mhi/core/Makefile
> > b/drivers/bus/mhi/core/Makefile
> > index 66e2700c9032..bc1469778cf8 100644
> > --- a/drivers/bus/mhi/core/Makefile
> > +++ b/drivers/bus/mhi/core/Makefile
> > @@ -1,3 +1,3 @@
> > -obj-$(CONFIG_MHI_BUS) := mhi.o
> > +obj-$(CONFIG_MHI_BUS) += mhi.o
> > 
> >  mhi-y := init.o main.o pm.o boot.o
> > 
> > Thanks,
> > Mani
> > 
> > > Thanks,
> > > Bhaumik
> > > 
> > > 'The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> > > Forum,\na Linux Foundation Collaborative Project'
> Hi Mani,
> 
> Yes I was just about to reply. I realized it was due to the Makefile change.
> I have fixed and
> tested it. The warnings are gone now. I will remove the patch.
> 

Where is the patch fixing this issue? I couldn't find it in my inbox.
I'll just post one as I need to send out the PR today.

Thanks,
Mani

> Thanks,
> Bhaumik
> 
> 'The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,\na Linux Foundation Collaborative Project'