lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Sep 2020 16:17:08 +0200 From: Philipp Zabel <p.zabel@...gutronix.de> To: Qinglang Miao <miaoqinglang@...wei.com>, Rob Herring <robh@...nel.org>, Tomeu Vizoso <tomeu.vizoso@...labora.com>, Steven Price <steven.price@....com>, Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch> Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH -next] drm/panfrost: simplify the return expression of cz_ih_hw_init() On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com> > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > index e68967338..ea8d31863 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -18,19 +18,13 @@ > > static int panfrost_reset_init(struct panfrost_device *pfdev) > { > - int err; > - > pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); > if (IS_ERR(pfdev->rstc)) { > dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->rstc)); > return PTR_ERR(pfdev->rstc); > } > > - err = reset_control_deassert(pfdev->rstc); > - if (err) > - return err; > - > - return 0; > + return reset_control_deassert(pfdev->rstc); > } > > static void panfrost_reset_fini(struct panfrost_device *pfdev) Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de> regards Philipp
Powered by blists - more mailing lists