linux-kernel - Re: [PATCH 3/3] objtool: check: Handle calling non-function symbols in other sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921144008.n6c37mgby772bs5i@treble>
Date:   Mon, 21 Sep 2020 09:40:08 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Julien Thierry <jthierry@...hat.com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org, mbenes@...e.cz
Subject: Re: [PATCH 3/3] objtool: check: Handle calling non-function symbols
 in other sections

On Mon, Sep 21, 2020 at 10:56:05AM +0100, Julien Thierry wrote:
> 
> 
> On 9/18/20 9:07 PM, Josh Poimboeuf wrote:
> > On Tue, Sep 15, 2020 at 08:53:18AM +0100, Julien Thierry wrote:
> > > Relocation for a call destination could point to a symbol that has
> > > type STT_NOTYPE.
> > 
> > Then shouldn't the callee be changed to STT_FUNC?
> > 
> 
> Not if it's a code symbol that does not follow standard calling convention.
> 
> It's really the same case as the !reloc, except this time it's in a
> different .text section.

Yeah, that makes sense.  I'll take this one as well.

-- 
Josh