linux-kernel - RE: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 15:27:27 +0000
From:   Tianxianting <tian.xianting@....com>
To:     Christoph Hellwig <hch@....de>, Keith Busch <kbusch@...nel.org>
CC:     "axboe@...com" <axboe@...com>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [v2] nvme: replace meaningless judgement by checking
 whether req is null

Thank you Keith, Christoph,
So I don't need to send v3 patch? 

-----Original Message-----
From: Christoph Hellwig [mailto:hch@....de] 
Sent: Tuesday, September 22, 2020 10:59 PM
To: Keith Busch <kbusch@...nel.org>
Cc: tianxianting (RD) <tian.xianting@....com>; axboe@...com; hch@....de; sagi@...mberg.me; linux-nvme@...ts.infradead.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] nvme: replace meaningless judgement by checking whether req is null

On Tue, Sep 22, 2020 at 07:57:05AM -0700, Keith Busch wrote:
> The commit subject is a too long. We should really try to keep these 
> to
> 50 characters or less.
> 
>   nvme-pci: fix NULL req in completion handler
> 
> Otherwise, looks fine.
> 
> Reviewed-by: Keith Busch <kbusch@...nel.org>

Yes.  I was about to apply it with a similar edit, but I'll take yours happily.