[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200922191538.GB12261@Red>
Date: Tue, 22 Sep 2020 21:15:38 +0200
From: LABBE Corentin <clabbe@...libre.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: gregkh@...uxfoundation.org, laurent.pinchart@...net.be,
mchehab@...nel.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH RFT/RFC 01/49] staging: media: Revert "media: zoran:
remove deprecated driver"
On Tue, Sep 22, 2020 at 06:16:01AM +0100, Christoph Hellwig wrote:
> > + fh->buffers.buffer[i].v4l.fbuffer = mem;
> > + fh->buffers.buffer[i].v4l.fbuffer_phys = virt_to_phys(mem);
> > + fh->buffers.buffer[i].v4l.fbuffer_bus = virt_to_bus(mem);
> > + for (off = 0; off < fh->buffers.buffer_size;
> > + off += PAGE_SIZE)
> > + SetPageReserved(virt_to_page(mem + off));
>
> This messing with SetPageReserved needs to go away before we bring
> back the driver, even for staging.
The whole old buffer management (with some virt_to_phys, virt_to_bus, SetPageReserved, etc...) is removed in "zoran: convert to vb2".
Regards
Powered by blists - more mailing lists