linux-kernel - [PATCH V2] x86/vector: print_APIC_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <613f58fe866eb6cc8a043aac5ec97fe9d8a0126d.camel@perches.com>
Date:   Mon, 21 Sep 2020 19:09:44 -0700
From:   Joe Perches <joe@...ches.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     Marc Zyngier <maz@...nel.org>, Andy Lutomirski <luto@...nel.org>,
        Ming Lei <ming.lei@...hat.com>, Peter Xu <peterx@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH V2] x86/vector: print_APIC_field - use print_hex_dump_debug

Convert the printk(KERN_DEBUG) / pr_cont uses to print_hex_dump_debug.

Output is now single line with spaces between output u32s.

Signed-off-by: Joe Perches <joe@...ches.com>
---
> On Mon, 2020-09-21 at 21:35 +0200, Borislav Petkov wrote:
> Forgot to use checkpatch on your patch:

V2: I've heard of it but rarely use it myself.

 arch/x86/kernel/apic/vector.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index f8a56b5dc29f..fd4b630ac4c1 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -1051,16 +1051,16 @@ int lapic_can_unplug_cpu(void)
 #endif /* HOTPLUG_CPU */
 #endif /* SMP */
 
-static void __init print_APIC_field(int base)
+static void __init print_APIC_field(const char *prefix, int base)
 {
 	int i;
+	u32 reads[8];
 
-	printk(KERN_DEBUG);
+	for (i = 0; i < ARRAY_SIZE(reads); i++)
+		reads[i] = apic_read(base + i*0x10);
 
-	for (i = 0; i < 8; i++)
-		pr_cont("%08x", apic_read(base + i*0x10));
-
-	pr_cont("\n");
+	print_hex_dump_debug(prefix, DUMP_PREFIX_NONE, 32, 4,
+			     reads, sizeof(reads), false);
 }
 
 static void __init print_local_APIC(void *dummy)
@@ -1109,12 +1109,9 @@ static void __init print_local_APIC(void *dummy)
 	v = apic_read(APIC_SPIV);
 	pr_debug("... APIC SPIV: %08x\n", v);
 
-	pr_debug("... APIC ISR field:\n");
-	print_APIC_field(APIC_ISR);
-	pr_debug("... APIC TMR field:\n");
-	print_APIC_field(APIC_TMR);
-	pr_debug("... APIC IRR field:\n");
-	print_APIC_field(APIC_IRR);
+	print_APIC_field("... APIC ISR field: ", APIC_ISR);
+	print_APIC_field("... APIC TMR field: ", APIC_TMR);
+	print_APIC_field("... APIC IRR field: ", APIC_IRR);
 
 	/* !82489DX */
 	if (APIC_INTEGRATED(ver)) {