linux-kernel - Re: [PATCH net-next] net: microchip: Make `lan743x_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200922.165428.1054729586492392023.davem@davemloft.net>
Date:   Tue, 22 Sep 2020 16:54:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhengyongjun3@...wei.com
Cc:     bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: microchip: Make `lan743x_pm_suspend`
 function return right value

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Mon, 21 Sep 2020 20:08:18 +0800

> @@ -3053,7 +3053,7 @@ static int lan743x_pm_suspend(struct device *dev)
>  	/* Host sets PME_En, put D3hot */
>  	ret = pci_prepare_to_sleep(pdev);
>  
> -	return 0;
> +	return ret;
>  }

Instead please do:

	return pci_preprare_to_sleep(pdev);

And if 'ret' is then completely unused as a result, remove it.