linux-kernel - RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless property of rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR0401MB243883AEA75F615A0768D03E8F3B0@DB6PR0401MB2438.eurprd04.prod.outlook.com>
Date:   Tue, 22 Sep 2020 03:31:28 +0000
From:   Biwen Li <biwen.li@....com>
To:     Leo Li <leoyang.li@....com>, Shawn Guo <shawnguo@...nel.org>,
        "Biwen Li (OSS)" <biwen.li@....nxp.com>
CC:     "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jiafei Pan <jiafei.pan@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove useless
 property of rtc

> 
> 
> 
> > -----Original Message-----
> > From: Biwen Li <biwen.li@....com>
> > Sent: Monday, September 21, 2020 10:13 PM
> > To: Shawn Guo <shawnguo@...nel.org>; Biwen Li (OSS)
> > <biwen.li@....nxp.com>
> > Cc: alexandre.belloni@...tlin.com; Leo Li <leoyang.li@....com>;
> > robh+dt@...nel.org; mark.rutland@....com; devicetree@...r.kernel.org;
> > linux-kernel@...r.kernel.org; Jiafei Pan <jiafei.pan@....com>; linux-
> > rtc@...r.kernel.org
> > Subject: RE: [EXT] Re: [PATCH 2/5] arm64: dts: lx2160a-rdb: remove
> > useless property of rtc
> >
> > >
> > > Caution: EXT Email
> > >
> > > On Tue, Sep 15, 2020 at 03:32:10PM +0800, Biwen Li wrote:
> > > > From: Biwen Li <biwen.li@....com>
> > > >
> > > > Remove useless property interrupts of rtc
> > > >
> > > > Signed-off-by: Biwen Li <biwen.li@....com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 --
> > > >  1 file changed, 2 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > index dce79018d397..e9e982176e07 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> > > > @@ -171,8 +171,6 @@
> > > >       rtc@51 {
> > > >               compatible = "nxp,pcf2129";
> > > >               reg = <0x51>;
> > > > -             // IRQ10_B
> > > > -             interrupts = <0 150 0x4>;
> > >
> > > If it's a correct description of hardware, I do not see why we would
> > > need to remove it.
> > Hi Shawn,
> >
> > Don't need use the interrupt, only read time from rtc.
> 
> User probably will choose to use the alarm feature of the RTC and need the
> interrupt property.  Is there any issue when the interrupt property is present?
Generic interrupt controller on layerscape only support  IRQ_TYPE_LEVEL_HIGH and  IRQ_TYPE_EDGE_RISING(except SoC LS1043A, LS1046A),
Not support IRQ_TYPE_LEVEL_LOW,
In drivers/rtc/rtc-pcf2127.c
ret = devm_request_threaded_irq(dev, alarm_irq, NULL,
pcf2127_rtc_irq,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
dev_name(dev), dev);

> 
> >
> > Best Regards,
> > Biwen Li
> > >
> > > Shawn
> > >
> > > >       };
> > > >  };
> > > >
> > > > --
> > > > 2.17.1
> > > >