linux-kernel - Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200922052701.GB16386@1wt.eu>
Date:   Tue, 22 Sep 2020 07:27:01 +0200
From:   Willy Tarreau <w@....eu>
To:     poeschel@...onage.de
Cc:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end
 of line

On Mon, Sep 21, 2020 at 04:46:43PM +0200, poeschel@...onage.de wrote:
> From: Lars Poeschel <poeschel@...onage.de>
> 
> Skip printing characters at the end of a display line. This fits to the
> behaviour we already had, that the cursor is nailed to last position of
> a line.

Just very old memories, but wasn't this used with the ability to shift
the display ? IIRC the HD44780 has a 2x64 chars buffer and you can make
the buffered characters appear when you shift the display. That's akin
to seeing the display as an adjustable window over the buffer. I don't
remember having used that feature, so if it didn't previously work, please
disregard my comment, I just want to be sure we don't break a feature
others might be relying on.

Willy