linux-kernel - Re: [PATCH] soc: actions: include header to fix missing prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 11:59:59 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Andreas Färber <afaerber@...e.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: actions: include header to fix missing prototype

On Sun, Sep 20, 2020 at 10:26:52PM +0200, Krzysztof Kozlowski wrote:
> Include the header with prototype of owl_sps_set_pg to fix:
> 
>   drivers/soc/actions/owl-sps-helper.c:16:5: warning: no previous prototype for 'owl_sps_set_pg' [-Wmissing-prototypes]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  drivers/soc/actions/owl-sps-helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/actions/owl-sps-helper.c b/drivers/soc/actions/owl-sps-helper.c
> index 291a206d6f04..e3f36603dd53 100644
> --- a/drivers/soc/actions/owl-sps-helper.c
> +++ b/drivers/soc/actions/owl-sps-helper.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/delay.h>
>  #include <linux/io.h>
> +#include <linux/soc/actions/owl-sps.h>
>  
>  #define OWL_SPS_PG_CTL	0x0
>  
> -- 
> 2.17.1
>