linux-kernel - Re: [PATCH v2] staging: hikey9xx: Fix incorrect assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200922094910.36501e57@coco.lan>
Date:   Tue, 22 Sep 2020 09:49:10 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yu Chen <chenyu56@...wei.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: hikey9xx: Fix incorrect assignment

Em Mon, 21 Sep 2020 22:21:47 +0100
Alex Dewar <alex.dewar90@...il.com> escreveu:

> In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
> default value is assigned to priv->eye_diagram_param, rather than to
> priv->tx_vboost_lvl. Fix this.
> 
> Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
> Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR)
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>

Patch looks good to me. I also double-checked if everything
works ok after this fix - although it should, as the DT I'm using
has "hisilicon,tx-vboost-lvl" property defined. So:

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Tested-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>



> ---
> v2: Fix my email address and a typo in title
> 
>  drivers/staging/hikey9xx/phy-hi3670-usb3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> index 42dbc20a0b9a..4fc013911a78 100644
> --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> @@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)
>  
>  	if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
>  				 &priv->tx_vboost_lvl))
> -		priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST;
> +		priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;
>  
>  	phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
>  	if (IS_ERR(phy))



Thanks,
Mauro