lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Sep 2020 10:04:30 +0200 From: Marek Szyprowski <m.szyprowski@...sung.com> To: Krzysztof Kozlowski <krzk@...nel.org>, Sangbeom Kim <sbkim73@...sung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org Subject: Re: [PATCH] clk: s2mps11: initialize driver via module_platform_driver Hi Krzysztof, On 21.09.2020 22:35, Krzysztof Kozlowski wrote: > The driver was using subsys_initcall() because in old times deferred > probe was not supported everywhere and specific ordering was needed. > Since probe deferral works fine and specific ordering is discouraged > (hides dependencies between drivers and couples their boot order), the > driver can be converted to regular module_platform_driver. > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com> > --- > drivers/clk/clk-s2mps11.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index 2ce370c804aa..aa21371f9104 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -267,18 +267,7 @@ static struct platform_driver s2mps11_clk_driver = { > .remove = s2mps11_clk_remove, > .id_table = s2mps11_clk_id, > }; > - > -static int __init s2mps11_clk_init(void) > -{ > - return platform_driver_register(&s2mps11_clk_driver); > -} > -subsys_initcall(s2mps11_clk_init); > - > -static void __exit s2mps11_clk_cleanup(void) > -{ > - platform_driver_unregister(&s2mps11_clk_driver); > -} > -module_exit(s2mps11_clk_cleanup); > +module_platform_driver(s2mps11_clk_driver); > > MODULE_DESCRIPTION("S2MPS11 Clock Driver"); > MODULE_AUTHOR("Yadwinder Singh Brar <yadi.brar@...sung.com>"); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
Powered by blists - more mailing lists