linux-kernel - Re: [PATCH] HID: alps: clean up indentation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 11:20:22 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Colin King <colin.king@...onical.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] HID: alps: clean up indentation issue

On Sun, 20 Sep 2020, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> There is an if statement that is indented too deeply, fix
> this by removing the extraneous tab.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/hid/hid-alps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
> index a9c2de95c5e2..3feaece13ade 100644
> --- a/drivers/hid/hid-alps.c
> +++ b/drivers/hid/hid-alps.c
> @@ -526,7 +526,7 @@ static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)
>  
>  	ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,
>  			&sen_line_num_y, 0, true);
> -		if (ret < 0) {
> +	if (ret < 0) {
>  		dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);

I am usually not taking whitespace fixes, but this one actually really 
does improve code readability, so I am taking this one. Thanks,

-- 
Jiri Kosina
SUSE Labs