linux-kernel - Re: [PATCH] udf: Remove redundant initialization of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200922092222.GC15112@quack2.suse.cz>
Date:   Tue, 22 Sep 2020 11:22:22 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udf: Remove redundant initialization of variable ret

On Tue 22-09-20 16:13:22, Jing Xiangfeng wrote:
> After commit 9293fcfbc181 ("udf: Remove struct ustr as non-needed
> intermediate storage"), the variable ret is being initialized with
> '-ENOMEM' that is meaningless. So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>

Thanks. I've queued the patch to my tree.

								Honza

> ---
>  fs/udf/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 1c42f544096d..c0c8068116c1 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -854,7 +854,7 @@ static int udf_load_pvoldesc(struct super_block *sb, sector_t block)
>  	uint8_t *outstr;
>  	struct buffer_head *bh;
>  	uint16_t ident;
> -	int ret = -ENOMEM;
> +	int ret;
>  	struct timestamp *ts;
>  
>  	outstr = kmalloc(128, GFP_NOFS);
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR