linux-kernel - Re: [PATCH 07/25] media: i2c: imx355: silence unused acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200922093726.GN26842@paasikivi.fi.intel.com>
Date:   Tue, 22 Sep 2020 12:37:26 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Pavel Machek <pavel@....cz>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Dongchun Zhu <dongchun.zhu@...iatek.com>,
        Shawn Tu <shawnx.tu@...el.com>,
        Ricardo Ribalda <ribalda@...nel.org>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@...el.com>,
        Hyungwoo Yang <hyungwoo.yang@...el.com>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Marco Felsch <m.felsch@...gutronix.de>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/25] media: i2c: imx355: silence unused acpi_device_id
 warning

Hi Krzysztof,

Thanks for the patchset!

I believe the I²C client has been dug up first as we've been dealing with
I²C devices all the time, and it's been a pattern. I don't see that as a
reason to reject the patches either though, it definitely cleans up the
drivers.

On Mon, Sep 21, 2020 at 06:23:24PM +0200, Krzysztof Kozlowski wrote:
> If driver is built without ACPI, the struct acpi_device_id won't be
> used:
> 
>   drivers/media/i2c/imx355.c:1836:36: warning:
>     'imx355_acpi_ids' defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/media/i2c/imx355.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 51245e71b411..8db287251f49 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -1833,7 +1833,7 @@ static const struct dev_pm_ops imx355_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(imx355_suspend, imx355_resume)
>  };
>  
> -static const struct acpi_device_id imx355_acpi_ids[] = {
> +static const struct acpi_device_id imx355_acpi_ids[]__maybe_unused = {

A space before __ perhaps?

Albeit this seems to be all, I can address that while applying if that's
ok.

>  	{ "SONY355A" },
>  	{ /* sentinel */ }
>  };

-- 
Kind regards,

Sakari Ailus